Skip to content

change dependency on hatchling of BeautifulSoup v4.12.2 to a build dependency#20546

Merged
smoors merged 1 commit intoeasybuilders:developfrom
lexming:20240517001458_new_pr_BeautifulSoup4122
May 17, 2024
Merged

change dependency on hatchling of BeautifulSoup v4.12.2 to a build dependency#20546
smoors merged 1 commit intoeasybuilders:developfrom
lexming:20240517001458_new_pr_BeautifulSoup4122

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented May 16, 2024 •
edited
Loading

(created using eb --new-pr)

I checked all easyconfigs depending on these easyconfigs of BeautifulSoup, and all of them already have explicit dependencies on hatchling or poetry. So no build failures should occur down the line.

IPython is a special case that has other issues, dealt with in #20547

@lexming lexming added the change label May 16, 2024
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented May 16, 2024

@boegelbot: please test @ generoso
EB_ARGS="BeautifulSoup-4.12.2-GCCcore-12.3.0.eb MONAI-1.3.0-foss-2023a.eb Cassiopeia-2.0.0-foss-2023a.eb PyTorch-Lightning-2.2.1-foss-2023a.eb"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 16, 2024

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=20546 EB_ARGS="BeautifulSoup-4.12.2-GCCcore-12.3.0.eb MONAI-1.3.0-foss-2023a.eb Cassiopeia-2.0.0-foss-2023a.eb PyTorch-Lightning-2.2.1-foss-2023a.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20546 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13478

Test results coming soon (I hope)...

Details

- notification for comment with ID 2116303307 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 16, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/b8f5c79db62f697694cb4607fea6d0ee for a full test report.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented May 16, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="BeautifulSoup-4.12.2-GCCcore-12.3.0.eb MONAI-1.3.0-foss-2023a.eb Cassiopeia-2.0.0-foss-2023a.eb PyTorch-Lightning-2.2.1-foss-2023a.eb"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 16, 2024

@lexming: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20546 EB_ARGS="BeautifulSoup-4.12.2-GCCcore-12.3.0.eb MONAI-1.3.0-foss-2023a.eb Cassiopeia-2.0.0-foss-2023a.eb PyTorch-Lightning-2.2.1-foss-2023a.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20546 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4137

Test results coming soon (I hope)...

Details

- notification for comment with ID 2116363526 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@lexming lexming mentioned this pull request May 16, 2024
Merged
1 task
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 16, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/0ae396cbc342779cfd1aebba8d62f493 for a full test report.

smoors
smoors approved these changes May 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added this to the release after 4.9.1 milestone May 17, 2024
@smoors
Copy link
Copy Markdown
Contributor

smoors commented May 17, 2024

Going in, thanks @lexming!

@smoors smoors merged commit 159b7f9 into easybuilders:develop May 17, 2024
@lexming lexming deleted the 20240517001458_new_pr_BeautifulSoup4122 branch May 17, 2024 13:12
@boegel boegel mentioned this pull request Sep 21, 2024
Merged
@boegel boegel mentioned this pull request Aug 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

change

Projects

None yet

Milestone

4.9.2

Development

Successfully merging this pull request may close these issues.

3 participants

@lexming @boegelbot @smoors